fix: encode URI path segments in navigation links - #4116
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 324 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4116 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15152 +5
Branches 4387 4382 -5
==========================================
+ Hits 14961 14965 +4
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Harness.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4116 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15152 +5
Branches 4387 4382 -5
==========================================
+ Hits 14961 14965 +4
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #4116 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15152 +5
Branches 4379 4390 +11
==========================================
+ Hits 14961 14965 +4
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4116 +/- ##
==========================================
- Coverage 98.77% 98.76% -0.01%
==========================================
Files 823 823
Lines 15147 15152 +5
Branches 4387 4390 +3
==========================================
+ Hits 14961 14965 +4
- Misses 179 180 +1
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Description
This PR addresses GAZEBO-1806, a
URIErrorthat occurred when navigating to pull request or commit tree views containing special characters (like%,[,]) in their path names. The error was caused bypullTreeView,commitTreeView, andpullFileViewinsrc/services/navigation/useNavLinks.tsdirectly interpolating rawtreepath strings into URLs without proper encoding.Code Example
The fix involves applying
encodeURIComponentto each segment of thetreepath in thepullTreeView,commitTreeView, andpullFileViewnavigation link builders withinsrc/services/navigation/useNavLinks.ts.Notable Changes
encodeURIComponentto path segments inpullTreeView,commitTreeView, andpullFileViewfunctions insrc/services/navigation/useNavLinks.ts.URIErrorduring route decoding.treeViewandfileViewerin the same file.Screenshots
N/A
Link to Sample Entry
N/A
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes GAZEBO-1806
This PR was automatically generated by Sentry. You can adjust this setting at any time.