Skip to content

fix: encode URI path segments in navigation links - #4116

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/uri-path-encoding
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/uri-path-encoding

Conversation

@sentry

@sentry sentry Bot commented Sep 10, 2026

Copy link
Copy Markdown

Description

This PR addresses GAZEBO-1806, a URIError that occurred when navigating to pull request or commit tree views containing special characters (like %, [, ]) in their path names. The error was caused by pullTreeView, commitTreeView, and pullFileView in src/services/navigation/useNavLinks.ts directly interpolating raw tree path strings into URLs without proper encoding.

Code Example

The fix involves applying encodeURIComponent to each segment of the tree path in the pullTreeView, commitTreeView, and pullFileView navigation link builders within src/services/navigation/useNavLinks.ts.

Notable Changes

  • Applied encodeURIComponent to path segments in pullTreeView, commitTreeView, and pullFileView functions in src/services/navigation/useNavLinks.ts.
  • Ensures proper URL encoding for special characters in file paths, preventing URIError during route decoding.
  • This change aligns the encoding strategy with treeView and fileViewer in the same file.

Screenshots

N/A

Link to Sample Entry

N/A

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes GAZEBO-1806

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 324 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.82MB 139 bytes (0.0%) ⬆️
gazebo-production-esm 5.89MB 185 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js 139 bytes 657.96kB 0.02%

Files in assets/index-legacy.*.js:

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.64kB
view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js 185 bytes 578.0kB 0.03%

Files in assets/index.*.js:

  • ./src/services/navigation/useNavLinks.ts → Total Size: 21.63kB

@sentry

sentry Bot commented Sep 10, 2026

Copy link
Copy Markdown
Author

⚠️ Seer needs additional GitHub permissions

Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix.

Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.76%. Comparing base (b8fbfc0) to head (cc8b435).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/navigation/useNavLinks.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files         823      823              
  Lines       15147    15152       +5     
  Branches     4387     4382       -5     
==========================================
+ Hits        14961    14965       +4     
- Misses        179      180       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 98.72% <87.50%> (-0.31%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.72% <ø> (ø)
Pages 98.43% <ø> (ø)
Services 99.29% <87.50%> (-0.03%) ⬇️
Shared 98.94% <ø> (ø)
UI 99.02% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fbfc0...cc8b435. Read the comment docs.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/navigation/useNavLinks.ts 87.50% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files         823      823              
  Lines       15147    15152       +5     
  Branches     4387     4382       -5     
==========================================
+ Hits        14961    14965       +4     
- Misses        179      180       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 98.72% <87.50%> (-0.31%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.72% <ø> (ø)
Pages 98.43% <ø> (ø)
Services 99.29% <87.50%> (-0.03%) ⬇️
Shared 98.94% <ø> (ø)
UI 99.02% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fbfc0...cc8b435. Read the comment docs.

@codecov-public-qa

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.76%. Comparing base (b8fbfc0) to head (cc8b435).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/services/navigation/useNavLinks.ts 87.50% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files         823      823              
  Lines       15147    15152       +5     
  Branches     4379     4390      +11     
==========================================
+ Hits        14961    14965       +4     
- Misses        179      180       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 98.72% <87.50%> (-0.31%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.72% <ø> (ø)
Pages 98.43% <ø> (ø)
Services 99.29% <87.50%> (-0.03%) ⬇️
Shared 98.94% <ø> (ø)
UI 99.02% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fbfc0...cc8b435. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-releaser

Copy link
Copy Markdown
Collaborator

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cc8b435 Thu, 10 Sep 2026 10:55:43 GMT Cloud Enterprise

@codecov-qa

codecov-qa Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.76%. Comparing base (b8fbfc0) to head (cc8b435).

Files with missing lines Patch % Lines
src/services/navigation/useNavLinks.ts 87.50% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
- Coverage   98.77%   98.76%   -0.01%     
==========================================
  Files         823      823              
  Lines       15147    15152       +5     
  Branches     4387     4390       +3     
==========================================
+ Hits        14961    14965       +4     
- Misses        179      180       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
src/services/navigation/useNavLinks.ts 98.72% <87.50%> (-0.31%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.72% <ø> (ø)
Pages 98.43% <ø> (ø)
Services 99.29% <87.50%> (-0.03%) ⬇️
Shared 98.94% <ø> (ø)
UI 99.02% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fbfc0...cc8b435. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant