fix(error-boundary): Guard against null data.detail in NetworkErrorBoundary - #4122
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 48 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4122 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4387 4387
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4122 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4387 4387
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #4122 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4379 4379
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4122 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4387 4387
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1 participant
DescriptionThis PR fixes GAZEBO-17HE, a
TypeError: Cannot read properties of null (reading 'detail')that occurred in theNetworkErrorBoundarycomponent.The error happened when an API response for statuses 401, 403, or 429 returned anullbody. Thedescriptionfunctions for these statuses ((data) => data.detail) would then attempt to access.detailonnull, causing a crash.The fix involves adding optional chaining (?.) to thesedescriptionfunctions insrc/layouts/shared/NetworkErrorBoundary/NetworkErrorBoundary.jsx, changingdata.detailtodata?.detail. This ensures that ifdataisnullorundefined, the expression safely evaluates toundefinedinstead of throwing an error, allowing the error UI to render gracefully.# Code Examplejavascript// Before(data) => data.detail// After(data) => data?.detail# Notable Changes- Added optional chaining (?.) todescriptionfunctions for 401, 403, and 429 status codes insrc/layouts/shared/NetworkErrorBoundary/NetworkErrorBoundary.jsx.- PreventsTypeError: Cannot read properties of null (reading 'detail')when API responses for these statuses return anullbody.# Screenshots# Link to Sample Entry# Legal BoilerplateLook, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.Fixes GAZEBO-17HE
This PR was automatically generated by Sentry. You can adjust this setting at any time.