refactor: remove BatchSelectionBar and BatchHotspotBar overlays - #5
Merged
Merged
Conversation
BatchSelectionBar and BatchHotspotBar render at position:fixed bottom-center at zIndex 900, directly overlapping the ToolBar at the same position. Hide ToolBar when canvasSelection or selectedHotspots are non-empty so the batch bar has clean screen space with no stale toolbar artifact beneath it.
All actions provided by these floating bars (delete, group, escape) are already accessible via keyboard shortcuts, making the bars redundant. Removing them eliminates the visual conflict with the persistent ToolBar.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchSelectionBarandBatchHotspotBarcomponent filesToolBarhiddenprop added toToolBarin the previous workaround commithotspotClipboardref fromuseHotspotInteraction(only served the now-removed copy/paste feature)Why
The bars were redundant — all their actions are already available via keyboard shortcuts (Delete/Backspace to delete, Cmd+G to group, Escape to cancel). The overlay conflict with
ToolBarwas the root symptom; this removes the cause rather than hiding one over the other.Test plan
npm run lint— no errorsnpm test— all 229 tests passToolBarstays visible and Delete, Cmd+G, Escape still work