docs(build): say why the okhttp dependency has no caller here - #201
Merged
Merged
Conversation
Nothing in this repository imports okhttp3, in main or in test, so the dependency reads as dead weight. It is not. It is how Fess comes to ship okhttp 5.x in WEB-INF/lib, and fess-ds-microsoft365 calls okhttp from its own code without shading it, excluding the okhttp 4.12.0 that Kiota brings so that it runs on the copy Fess supplies. Deleting it would break that plugin with a NoClassDefFoundError at crawl time, and no test in this repository would catch it. I nearly deleted it while auditing the distribution for unused jars, which is what this comment is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #200.
Nothing in this repository imports
okhttp3, in main or in test, socom.squareup.okhttp3:okhttp-jvmreads as dead weight in a dependency audit. It is not.It is how Fess comes to ship okhttp 5.x in
WEB-INF/lib.fess-ds-microsoft365calls okhttp from its own code and deliberately does not shade it — its pom excludes the okhttp 4.12.0 that Kiota brings, with the comment:Deleting this declaration would break the Microsoft 365 data store with a
NoClassDefFoundErrorat crawl time, and no test in this repository would catch it.I nearly deleted it while auditing the distribution for unused jars — grep over this repo and over codelibs/fess found no caller. That is exactly the failure this comment exists to prevent. Comment only, no behaviour change.