Skip to content

build!: leave the gcs: crawler client to the fess-lib-gcs plugin #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marevol merged 1 commit into from
Sep 9, 2026
Merged

build!: leave the gcs: crawler client to the fess-lib-gcs plugin #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions fess-crawler-lasta/src/main/resources/crawler/client.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,12 @@
<property name="charset">"UTF-8"</property>
</component>

<component name="gcsClient"
class="org.codelibs.fess.crawler.client.gcs.GcsClient" instance="prototype">
<property name="charset">"UTF-8"</property>
</component>
<!-- gcs: has no client registered here. GcsClient stays in this library, but the Google Cloud
Storage SDK it needs is 17 MiB that most installations never crawl, so Fess ships it in the
fess-lib-gcs plugin, which registers the client through crawlerClientCreator the way
fess-crawler-playwright registers playwrightClient. Registering it here instead would make
every CrawlerClientFactory fail to build wherever the SDK is absent, because the component
reference below is resolved when the factory is created. -->

<component name="crawlerClientCreator"
class="org.codelibs.fess.crawler.client.CrawlerClientCreator">
Expand Down Expand Up @@ -95,10 +97,6 @@
<arg>"s3:.*"</arg>
<arg>s3Client</arg>
</postConstruct>
<postConstruct name="addClient">
<arg>"gcs:.*"</arg>
<arg>gcsClient</arg>
</postConstruct>
</component>

</components>
Loading