chore(deps): drop httpclient-cache, which nothing uses - #210
Merged
Merged
Conversation
No class in fess-crawler, in Fess or in any plugin repository refers to org.apache.http.impl.client.cache, so the dependency only adds 0.15 MiB to every Fess distribution. httpclient and httpcore 4.x are unaffected: Hc4HttpClient and fess-ds-sharepoint still use them, and they are declared on their own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpclient-cacheis declared by fess-crawler, but no class in fess-crawler, in Fess, or in any plugin repository refers toorg.apache.http.impl.client.cache— checked against the current snapshot jar of every plugin, not only their sources. It adds 0.156 MiB to every Fess distribution.httpclientandhttpcore4.x are declared on their own and are unaffected:Hc4HttpClientand fess-ds-sharepoint still use them.Verification
httpclient-cacheand nothing else.mvn clean testagainst this build: 7,486 tests, 0 failures, 0 errors.mvn -pl fess-crawler -am test: 2,057 tests, 2 failures, neither related to this change:Hc5HttpClientTest.test_doHead_accessTimeoutTargetfailed while other builds loaded the machine and passes when run alone.CommandExtractorTest.test_processDescendants_killed_orphan_gonelooks for any livesleep 30process on the machine, and an unrelated shell loop on the test machine was running one.