chore(workspace): track the fess-storage-* and fess-sso-* plugin repositories - #35
Merged
Merged
Conversation
…sitories 15.9 moves the S3 and GCS storage clients and the four SSO authenticators out of the Fess distribution, so sets/all.yaml now clones and builds the six repos that carry them: fess-storage-s3, fess-storage-gcs, fess-sso-saml, fess-sso-spnego, fess-sso-entraid and fess-sso-oidc. All six default to main. That takes the set from 48 repositories to 54 -- fess-storage-gcs had never been added, so this covers the GCS split as well as the ones just extracted. README.md gains a table per group, with the sso.type / storage.type value each plugin serves. fess-sso-oidc is the one place the repo name and the type differ, since the type stays oic. The prose says what core keeps: SsoManager resolving <sso.type>Authenticator, StorageClientFactory resolving <storage.type>StorageClient, with the implementation and the SDK in the plugin, and the s3:/gcs: crawler client registered by the plugin around a class that stays in fess-crawler. plugins.yaml is left alone: it covers data stores only, which the README now says outright rather than leaving a reader to infer it. CLAUDE.md records where the code went, so a grep of repos/fess that comes up empty is not a surprise: the storage half is already on master, the SSO half is codelibs/fess#3430. It also records the version-pairing constraint -- an SSO plugin from a different minor than the war registers the same component name twice, because core ships its own fess_sso++.xml up to 15.8 and LastaDi merges every ++ file on the class path, so container.init() succeeds and getComponent() then throws TooManyRegistrationComponentException. Storage has no counterpart before 15.9: fess_storage.xml and the <storage.type>StorageClient lookup are both new. And a plugin repo's prefix is also its PluginHelper.ArtifactType, where STORAGE and SSO were added in 15.9. Skills: - fess-doc-review/refs/source-mapping.md: the four SSO rows and three new storage rows point at the plugin repos, each naming what stayed in core -- sso.type and the entraid keys with their aad fallback in FessProp, StorageClientFactory's lookup, StorageType's endpoint detection -- plus a note on where the same classes live when reviewing 15.8 or earlier docs. The OIDC credential also changed package, out of org.codelibs.fess.app.web.base.login. - fess-version-bump: fess-sso-* and fess-storage-* belong to wave 5. The script derives its list from all.yaml, so only the documented wave needed an edit. - fess-tech-doc: both plugin families added to the "where to look" list. Verified by parsing sets/all.yaml with the workspace's own yaml_parser.sh (54 repositories, the six resolving to main), cloning all six, and running status.sh --short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six repositories carry features that 15.9 moves out of the Fess distribution, and none of them were tracked here.
sets/all.yamlnow clones and builds them, taking the set from 48 repositories to 54:fess-storage-s3storage.type=s3(and thes3_compatauto-detection),s3:crawlingfess-storage-gcsstorage.type=gcs,gcs:crawlingfess-sso-samlsso.type=samlfess-sso-spnegosso.type=spnegofess-sso-entraidsso.type=entraid, and the legacyaadfess-sso-oidcsso.type=oic— the one place a repo name and its type differAll six default to
main.fess-storage-gcshad never been added, so this covers the GCS split as well as the ones just extracted.Documentation
README.md gets a table per group plus what core keeps —
SsoManagerresolving<sso.type>Authenticator,StorageClientFactoryresolving<storage.type>StorageClient— with the implementation and its SDK in the plugin, and thes3:/gcs:crawler client registered by the plugin around a class that stays infess-crawler.plugins.yamlis deliberately untouched. It covers data stores only, which the README now states rather than leaving a reader to infer it from the list. Its three entries that are not inall.yaml(fess-ds-office365,-s3,-gitbucket) already carry a gotcha;fess-ds-office365is archived upstream.CLAUDE.md records where the code went, so a grep of
repos/fessthat comes up empty is not a surprise — the storage half is already onmaster, the SSO half is codelibs/fess#3430 — plus the version-pairing constraint and the fact that a plugin repo's prefix is also itsPluginHelper.ArtifactType(STORAGEandSSOwere added in 15.9).Skills
fess-doc-review/refs/source-mapping.md— the four SSO rows and three new storage rows point at the plugin repos, each naming what stayed in core:sso.typeand theentraid.*keys with theiraad.*fallback inFessProp,StorageClientFactory's lookup,StorageType's endpoint detection. A note says where to read the same classes when reviewing 15.8 or earlier docs. The OIDC credential also changed package, out oforg.codelibs.fess.app.web.base.login.fess-version-bump—fess-sso-*andfess-storage-*belong to wave 5. Only the documented wave needed the edit;scripts/lib.shderives its list fromall.yamland picked them up unchanged.fess-tech-doc— both plugin families added to the "where to look" list.Verified
sets/all.yamlparsed with the workspace's ownyaml_parser.sh: 54 repositories, the six resolving tomain.status.sh --shortreports 54 repositories and each new checkout clean onmain.fess_sso++.xmlon15.8.xdeclares all four authenticators, while15.8.xhas nofess_storage.xmland nos3StorageClientcomponent — which is why the double-registration paragraph is scoped to SSO.FessProponmasterkeeps thestorage.*accessors,sso.type, andentraid.permission.fields/entraid.use.dswith theaad.*fallback, so those rows say "still in core" rather than moving them to the plugins.PluginHelper.ArtifactTypeonmasterhasSTORAGE("fess-storage")andSSO("fess-sso").