Skip to content

fix(setup): fail check on a plugin built for another release - #3456

Merged
marevol merged 1 commit into
mainfrom
fix/setup-check-fails-on-a-plugin-for-another-release
Sep 16, 2026
Merged

marevol merged 1 commit into
mainfrom
fix/setup-check-fails-on-a-plugin-for-another-release

Conversation

@marevol

@marevol marevol commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

fess-setup check reported a plugin jar built for another Fess release as WARN, printed Usable, with warnings. and exited 0. The upgrade guide says those jars have to be replaced, and between releases the war changes under a plugin: 15.9 moved the OpenSearch classes into another package and stopped shipping libraries that 15.8 plugins took from it. Such a jar can keep Fess from starting at all.

Measured with fess-webapp-mcp 15.8.0 left in WEB-INF/plugin of a 15.9 build: the DI container failed to initialize (NoClassDefFoundError on a nimbus class), every page and API answered 404. check still exited 0:

WARN  plugin fess-webapp-mcp        15.8.0 was built for another release (this Fess is 15.9)
Usable, with warnings.

Changes

  • Diagnostics#installedPlugins: a plugin for another release is a FAIL, and the line names the remedy. check then exits 1 and can gate a deployment as the command intends:

    FAIL  plugin fess-webapp-mcp        15.8.0 was built for another release (this Fess is 15.9; replace it with: fess-setup upgrade plugins)
    Something is wrong. See the FAIL lines above.
    
  • A snapshot of this release's line, such as 15.9.0-20260914.212412-2, is still OK.

Verification

  • test_installedPlugins_failsWhenAPluginIsForAnotherRelease (replacing the WARN test) fails on main and passes with this change. New: test_installedPlugins_acceptsASnapshotOfThisRelease.
  • DiagnosticsTest and FessSetupTest: 56 tests pass.
  • On a 15.9 build with the 15.8.0 plugin jar in place:
    • check prints the FAIL line above and exits 1.
    • fess-setup upgrade plugins then replaced the jar with the 15.9 build and Fess started. It was already correct.
    • check then reports the plugin OK and exits 0.

The 15.9 documentation describes this check line as a warning; codelibs/fess-docs#539 updates it.

fess-setup check reported a plugin jar built for another Fess release as WARN,
printed "Usable, with warnings." and exited 0. The upgrade guide says those jars
have to be replaced, and between releases the war changes under a plugin: 15.9
moved the OpenSearch classes into another package and stopped shipping libraries
that 15.8 plugins took from it. Such a jar can keep Fess from starting at all.
Measured with fess-webapp-mcp 15.8.0 left in WEB-INF/plugin of a 15.9 build: the
DI container fails to initialize, every page and API answers 404, and check still
exited 0 with the WARN line.

A plugin for another release is now a FAIL, so check exits 1 and can gate a
deployment as intended, and the line names the remedy:

  FAIL  plugin fess-webapp-mcp  15.8.0 was built for another release (this Fess
        is 15.9; replace it with: fess-setup upgrade plugins)

A snapshot of this release's line, such as 15.9.0-20260914.212412-2, is still OK.
fess-setup upgrade plugins itself was already correct: in the same installation it
replaced the 15.8.0 jar with the 15.9 build and Fess started.
@marevol marevol added this to the 15.9.0 milestone Sep 16, 2026
@marevol marevol self-assigned this Sep 16, 2026
@marevol
marevol merged commit a935a45 into main Sep 16, 2026
2 checks passed
marevol added a commit to codelibs/fess-docs that referenced this pull request Sep 16, 2026
…check (#539)

codelibs/fess#3456 turns the check line for a plugin jar built for another Fess
release from a warning into a failure, because such a jar can keep Fess from
starting at all. The check section of install/fess-setup.rst in the 15.9 tree
described it as a warning; update the sentence in all seven languages.
@marevol
marevol deleted the fix/setup-check-fails-on-a-plugin-for-another-release branch September 17, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant