Remove website JavaScript build login#5434
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the obsolete website CI/login path for JavaScript builds by deleting Keycloak token exchange and CN1 credential seeding, and switching the website workflow to always build/validate the Initializr and Playground bundles via the local ParparVM JavaScript target (no secrets required).
Changes:
- Removed
CN1_USER/CN1_TOKENhandling and Keycloak token exchange logic from the website build script. - Made Initializr and Playground inclusion unconditional when set to
auto, and removed token-seeding steps from the JS app build flow. - Updated the website workflow to always build/validate Initializr and Playground outputs without credential-gated checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/website/build.sh | Removes credential-based gating and Keycloak/token-seeding logic so JS apps build via the local ParparVM path without login. |
| .github/workflows/website-docs.yml | Drops secrets wiring and always validates generated Initializr/Playground JS bundle outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CN1_USERorCN1_TOKENsecretsRoot cause
The website workflow still attempted to log in before building its JavaScript apps. Keycloak has been taken down, so that stale request now fails with HTTP 522 even though ParparVM JavaScript builds are free and no longer require authentication.
Impact
Website builds no longer depend on the retired authentication service. Initializr, Playground, and Skin Designer use the existing local ParparVM build path without credentials.
Validation
bash -n scripts/website/build.sh.github/workflows/website-docs.ymlwith Ruby YAMLgit diff --checkCN1_USER/CN1_TOKEN, or token-seeding references remain in the website build path