Fix iOS debug proxy dependency resolution#5435
Open
shai-almog wants to merge 1 commit into
Open
Conversation
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 151 screenshots: 151 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Collaborator
Author
|
Compared 181 screenshots: 181 matched. |
Collaborator
Author
|
Compared 217 screenshots: 217 matched. |
Collaborator
Author
|
Compared 149 screenshots: 149 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 144 screenshots: 144 matched. |
Collaborator
Author
|
Compared 143 screenshots: 143 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 148 screenshots: 148 matched. Benchmark Results
Detailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cn1-debug-proxyas a runtime dependency of the Codename One Maven plugin~/.m2Root cause
cn1:ios-on-device-debuggingsearched every locally cached proxy version and launched the first standalone jar returned by the filesystem. Updating the Maven plugin therefore neither guaranteed that the matching proxy was downloaded nor that it was selected, which led users to manually rundependency:get.With this change, Maven resolves the proxy version pinned to
${project.version}as part of the plugin itself. Running the debugging goal no longer requires a separate proxy download and cannot silently select an older cached version.Related to #5333.
Validation
mvn -pl cn1-debug-proxy,codenameone-maven-plugin -DunitTests=true -Dmaven.javadoc.skip=true test— 268 tests passed, 1 skippedcn1-debug-proxyandcodenameone-maven-plugingit diff --check