fix(git-clone): scan custom SSH ports - #1093
Conversation
|
@35C4n0r The TF Tests are failing so if you can resolve that we are good but other that that I tested and everything works fine |
@DevelopmentCats transient error, re-ran the tests and everything passes now. |
Yeah I was looking at it and just came to the same conclusion approving now |
DevelopmentCats
left a comment
There was a problem hiding this comment.
Oh wait @35C4n0r You need to bump the version
|
intresting |
|
You know what I think there may be an unreleased PR for git-clone let me look into it |
|
Yep it was #1127 |
|
version bump done. |
Description
The git-clone module scanned SSH host keys on port 22 even when an
ssh://repository URL specified a custom port, causing host-key verification to fail for self-hosted Git services on ports such as 2222.Parse the host and port from
ssh://URLs, use the port-specific[host]:portidentity for known-host lookups, and pass the port tossh-keyscan. Preserve scp-style URL behavior and add regression coverage for custom-port and existing-key cases.Type of Change
Module Information
Path:
registry/coder/modules/git-cloneNew version:
v2.0.5Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
Fixes #1073
Fixes REG-93
Generated by Coder Agents for @35C4n0r.