-
Notifications
You must be signed in to change notification settings - Fork 162
feat(registry/coder/modules/aws-region): regions.json catalog, default_availability_zone output, optional parameter #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
phorcys420
wants to merge
12
commits into
main
Choose a base branch
from
phorcys/aws-region-availability-zone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
df23374
feat(registry/coder/modules/aws-region): store regions in regions.jso…
phorcys420 4c5c12f
feat(registry/coder/modules/aws-region): optional parameter, in-modul…
phorcys420 952331c
fix(registry/coder/modules/aws-region): render options under dynamic …
phorcys420 ec4b128
Merge branch 'main' into phorcys/aws-region-availability-zone
phorcys420 814134b
test(registry/coder/modules/aws-region): restore tests and add input …
phorcys420 03ba5e4
refactor(registry/coder/modules/aws-region): default variable to null
phorcys420 e53d5f8
fix(registry/coder/modules/aws-region): use consistent Europe region …
phorcys420 7b2d910
refactor(registry/coder/modules/aws-region): rename region field to flag
phorcys420 7408129
docs(registry/coder/modules/aws-region): make regions.json update a s…
phorcys420 e24846c
refactor(registry/coder/modules/aws-region): derive flag in terraform
phorcys420 91b47ba
refactor(registry/coder/modules/aws-region): simplify flags to one map
phorcys420 0fdb972
refactor(registry/coder/modules/aws-region): move region icons into r…
phorcys420 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
_?