Fix normal room chat layout#249
Merged
Merged
Conversation
Make the chat rail own its width and collapse cleanly, and allow the local client origin to complete WCA login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://localhost:3000in development CORS so the local WCA login callback can completeRoot cause
The normal room gave both layout columns equal flex growth while Chat itself used a fixed width. That left a blank area beside chat, and collapsing only the inner panel left the outer column and an absolutely positioned toolbar behind. Separately, the local API did not allow the full Vite browser origin for credentialed callback requests.
Validation
yarn workspace letscube-client test:ciyarn workspace letscube-client buildyarn workspace letscube-server test cors.test.jsyarn lintandyarn test(all suites passed)