Skip to content

Conflicts with OhMyZsh macos plugin #1

Description

@doctorfree

I love this kind of thing. Good work.

However, the music function already exists in the macos plugin for Zssh at https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/macos

I was able to simply change music to amusic in zshMusic.zsh to get it to work.

I would recommend either renaming the music function so it does not conflict with a popular OhMyZsh plugin or contributing your work to the macos plugin as it looks like yours has more functionality.

Also, there is a typo in tthe README - source ~/add-to-your-.zshrc/zshMusic/zshmusic.zsh should be source ~/add-to-your-.zshrc/zshMusic/zshMusic.zsh (capitalize the M).

Thanks for this cool tool!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions