fix(test): wait for PostgreSQL TCP readiness - #185
Merged
Merged
Conversation
Signed-off-by: wayne <rcywjo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Post-Merge Full source regression on main
69d71616ba8f78066786aacd241b840e916cd94cfailed incontrold-postgres-test: node enrollment E2E reached PostgreSQL while it was still starting (SQLSTATE 57P03). The script usedpg_isreadywithout a host, so the official image socket-only bootstrap server satisfied readiness before the final TCP server was available to the tests.Fix
Probe final PostgreSQL TCP readiness in the control-plane integration runner and the directly related CLI E2E runner. Keep the CLI database existence query on the local socket to avoid passing a test password on a command line. The probe remains bounded and fails closed; no retries are added to application code or assertions relaxed.
Verification
listen_addresses.make controld-postgres-testwith a fresh container passed, includingTestNodeEnrollmentTLSPostgresE2E.make cli-e2e-environment-contract, shell syntax checks,git diff --check, and Forgemake axern-cn-verify-changedpassed.Release Check for the older main SHA was canceled before final publication. v0.11.4 tags remain unused. After this fix merges, restart Release Check on the new exact main SHA; do not reuse the canceled candidate.