Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the handling of Shiny validation in the pcaWithVar function to support usage both within and outside Shiny applications. The main improvement allows the function to gracefully handle data validation errors in non-Shiny contexts by issuing warnings and returning NULL, rather than attempting to use Shiny's validate() function which only works within reactive contexts.
Key changes:
- Modified
pcaWithVarto conditionally use Shiny validation based on runtime context - Added proper data documentation tags (
@docType data,@usage) for dataset documentation - Updated package metadata (version bump from 1.11.2 to 1.13.1, RoxygenNote 7.3.2 → 7.3.3)
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| R/PrepareData.R | Added conditional Shiny runtime detection for validation logic; reformatted indentation throughout multiple functions |
| R/protein_expression.R | Added @docType data and @usage annotations to dataset documentation |
| R/artificial_clusters.R | Added @docType data and @usage annotations to dataset documentation |
| NAMESPACE | Added isRunning import from shiny package to support new conditional logic |
| DESCRIPTION | Updated package version to 1.13.1 and RoxygenNote to 7.3.3 |
| man/protein_expressions.Rd | Updated documentation usage section to use data() function syntax |
| man/artificial_clusters.Rd | Updated documentation usage section to use data() function syntax |
| man/pcaWithVar.Rd | Auto-generated documentation reflecting changes to source roxygen comments |
| inst/docker/Dockerfile | Commented out RDAVIDWebService installation (dependency removal) |
| ..Rcheck/00check.log | Updated R version and compiler information in check log |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.