feat(pnpm-policy): list first-party packages inline with packages - #131
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review complete. No issues found — approved ✅. The change reworks
Reviewed commit: 57999b1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
packages:key topnpm-policy.yamlso a workspace can claim first-party names directly, without a registry query (maintainers) or a version-pinned inventory package (inventory).Why: fresh pgpm scaffolds pin
@constructive-io/pnpm-policy@0.3.2, whose inventory was generated 2026-08-05.graphile-storage-registryisn't in it, so a new scaffold'spnpm installfailsERR_PNPM_NO_MATURE_MATCHING_VERSIONon our own package — and stays broken until someone merges the weekly inventory PR, publishes, and bumps the pin. A list of names we own shouldn't be a versioned artifact.Semantics in
buildExclude:known = inventory.packages ∪ config.packages; names covered by a scope glob are still dropped.intersect.maintainerswithout aninventoryis now allowed whenpackages(orscopes) is set.Companion: the pgpm-boilerplates templates will drop the two pinned inventory devDependencies and list names via
packages:once this is published.Link to Devin session: https://app.devin.ai/sessions/dd4055c50bcf4b1e8e604211038aaa82
Open in Devin Desktop: https://app.devin.ai/desktop/session/dd4055c50bcf4b1e8e604211038aaa82?variant=devin
Requested by: @pyramation