fix(policy): intersect the inventory with the scaffold lockfile — only used first-party names are exempted - #58
Merged
Merged
Conversation
…ly used first-party names are exempted
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review complete. No issues found — approved ✅. This change introduces generated pnpm configuration YAML files (pnpm-policy.yaml and pnpm-workspace.yaml) into the pgpm and pnpm workspace boilerplate templates. All four files are declarative key-value configuration with no executable logic; the triage classified all files as skips and no specialist lenses or domain clusters apply. Because no changed file contains procedural code, no findings were produced. Reviewed commit: 02eb935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #57. Both workspace templates (
pgpm/,pnpm/) hadintersect: false, so the committedpnpm-workspace.yamla new user gets frompgpm init workspaceexempted every one of the ~890 inventory names (@cosmos-kit/*,create-akash-app, …) fromminimumReleaseAge— packages no scaffold uses. That's misleading, and not how pnpm-policy is meant to be used.pnpm-policy.yaml(both templates):intersect: false→intersect: true(the pnpm-policy default). Scope globs are never intersected, and the explicitpackages:claims from fix(policy): freshpgpm init workspacemust install our own packages on release day; CI now proves it #57 survive intersection, so release-day installs still work.pnpm-workspace.yamlregenerated bypnpm run policyinside a real scaffold (pgpm init workspace+pgpm init+pnpm installagainst the registry), then copied back — the generator needs a lockfile to intersect against, and the template dir itself has none. Result: 6 scope globs + 75 (pgpm) / 8 (pnpm) first-party names, down from ~890.Verified by re-scaffolding from the regenerated templates:
pnpm install(no release-age override),pnpm run policy:check,pnpm build,pnpm testall pass. Thescaffold.ymlworkflow from #57 runs the same flow in CI.Same fix in pglite-boilerplates #8, dashboard #271, brand-kit #4, agents-demo-testing #2.
Link to Devin session: https://app.devin.ai/sessions/d34558e831ad4bbf986f64cc4bd509bd
Open in Devin Desktop: https://app.devin.ai/desktop/session/d34558e831ad4bbf986f64cc4bd509bd?variant=devin
Requested by: @pyramation