test/system: Ensure that the local temporary Docker registry is ready#1817
Conversation
... before proceeding to avoid potential races. Some changes by Debarshi Ray. containers#1811 containers#1817 Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
debarshiray
force-pushed
the
wip/rishi/test-system-libs-helpers-ensure-docker-registry-is-ready
branch
from
d484a38 to
fd7a49d
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new helper function _wait_for_docker_registry to wait for the local Docker registry to become ready before attempting to log in. The review feedback suggests executing this helper function using BATS' run and assert_success for consistent error handling, and simplifying the double subshell redirection used to capture stderr from the openssl command.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Rolv-Apneseth
left a comment
Rolv-Apneseth
left a comment
There was a problem hiding this comment.
Some very minor suggestions but LGTM
... before proceeding to avoid potential races. Some changes by Debarshi Ray. containers#1811 containers#1817 Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
debarshiray
force-pushed
the
wip/rishi/test-system-libs-helpers-ensure-docker-registry-is-ready
branch
from
fd7a49d to
e764906
Compare
|
Thanks for taking a look, @Rolv-Apneseth ! |
... before proceeding. This will avoid potential races. Some changes by Debarshi Ray. containers#1811 containers#1817 Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
debarshiray
force-pushed
the
wip/rishi/test-system-libs-helpers-ensure-docker-registry-is-ready
branch
from
e764906 to
1a1b2e4
Compare
... before proceeding. This will avoid potential races. Some changes by Debarshi Ray. containers#1811 containers#1817 Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
debarshiray
force-pushed
the
wip/rishi/test-system-libs-helpers-ensure-docker-registry-is-ready
branch
from
1a1b2e4 to
6129f60
Compare
|
Looking good. Once this is merged feel free to close #1811 |
debarshiray
deleted the
wip/rishi/test-system-libs-helpers-ensure-docker-registry-is-ready
branch
|
Thanks for all the reviews and suggestions! |
Aha, it was one of those rare occurrences in the wild of port 50000 being unavailable on the host: While trying to trigger the error paths locally to test the changes in this pull request, I found that one way to trigger this is to simultaneously run the test suite more than once. Do you want to attempt a fix for this, @Rolv-Apneseth ? |
Sure yes |
2 participants
... before proceeding to avoid potential races.
Some changes by Debarshi Ray.
#1811