Scope credential sidecar denylist and bare row drop to avoid false positives - #1002
Merged
TheGreatAxios merged 1 commit intoSep 13, 2026
Conversation
Workspace files such as .vscode/settings.json.lock and <base>.<pid>.tmp were denied by the generic settings.json/permissions.json sidecar legs. Restricting those legs to the settings directory keeps decoys usable while real settings-sidecars still deny. fix(config): keep proxy bare rows alongside OAuth entries The CL-5606 legacy bare codex/xai drop now compares the row baseURL against the OAuth endpoint first, so a proxy or mirror row is preserved.
TheGreatAxios
marked this pull request as ready for review
September 13, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two over-eager gates from CL-7929:
settings.json/permissions.json.lock/.tmpsidecar denylist legs to the settings dir (matching the.baklegs), so workspace decoys such as.vscode/settings.json.lockand<base>.<pid>.tmpno longer deny. Real settings-dir sidecars still deny.codex/xairow drop on baseURL equality with the OAuth endpoint, so a bare row pointed at a proxy/mirror is kept alongside the credential-backed entries.Verification
bun run check— exit 0 (lint, typecheck, build, projects-dir guard, full suite: 7304 pass, 0 fail across 501 files)src/auth/credential-surface.test.ts(CL-7929 decoy no-deny + settings-dir true-positive deny)src/config/oauth-catalog.test.ts(proxy/mirror baseURL rows survive; legacy OAuth-endpoint rows still drop)Fixes CL-7929