Unify permission verdict path with a mode-invariant catastrophic deny - #1037
Merged
TheGreatAxios merged 2 commits intoSep 14, 2026
Conversation
Move the catastrophic shell deny to the top of the gate's single verdict path so every entry denies before auto-allow, prompting, grants, and skipPermissions; the gate becomes the sole enforcement owner, the authz plugin is removed, and grant coverage routes through one function. Scoped suite passes 1132/0 with typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Single verdict path through decide() with the catastrophic shell deny above the skipPermissions shortcut (strictly narrows allows, no widening); grant evaluation unified on approvalCoversSubject (byte-identical delegation); pass-through authz plugin deleted with chain ordering preserved. Verification: scoped permission/plugins/shell suites 1154/0, agent-tools suite 22/0, typecheck clean; independent review found no allow-widening. Fixes CL-7950