Skip to content

Give the two-attempt watchdog stall test an explicit 10s timeout #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 14, 2026
Merged

Give the two-attempt watchdog stall test an explicit 10s timeout #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/test-parallel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ describe("runWithWatchdog", () => {
expect(result.attempts).toBe(1);
});

// Two stall windows (2 x 1.5s) plus kill/retry overhead exceed the
// default 5s timeout when a delayed first tick doubles one attempt
// (tickMs == stallMs with a strict `>` check fires on the second tick).
test("gives up after the final attempt with exit code 1", async () => {
const stalls: [number, number][] = [];
const result = await runWithWatchdog({
Expand All @@ -126,7 +129,7 @@ describe("runWithWatchdog", () => {
expect(result.attempts).toBe(2);
// The final stall is reported by the exit code, not a retry notice.
expect(stalls).toEqual([[1, 2]]);
});
}, 10_000);

test("kills the whole process group, including the child's own children", async () => {
const dir = mkdtempSync(join(tmpdir(), "test-parallel-group-"));
Expand Down
Loading