Add plugin uninstall and a how-to header to /plugins - #763
TheGreatAxios merged 3 commits into
Conversation
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
Review · Comment
/plugins uninstalls owned installs, disables bundled plugins, and opens with a how-to header.
GitHub will not accept an approve from the PR author. Residual note: Claude marketplace disable writes enabled: false rather than dropping the settings key so shadowed bundled commands stay off.
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
Critic · Comment
/plugins uninstalls owned installs, disables bundled and Claude marketplace plugins with enabled: false, and opens with a how-to header. Confirm uses session cwd. Web chooser does not inherit Alt+X.
No blocking defects on the current branch.
Notes
- Alt+A now works on empty-list, warnings, and Close rows so the advertised how-to is true.
- Runner
pluginsAdmin.removeglue is still untested (surface tests stubremove). Not a merge blocker.
TheGreatAxios
left a comment
TheGreatAxios
left a comment
There was a problem hiding this comment.
Critic · Comment
/plugins uninstalls owned installs, disables bundled and Claude marketplace plugins with enabled: false, and opens with a how-to header. Confirm and ownership use session cwd. Web chooser and confirm pane do not inherit Alt+X.
No blocking or should-fix defects on this round.
This round
executePluginRemoveis extracted; runner passesconfig.cwd.- Missing paths outside the origin plugins root are refused; dangling symlinks inside are removed.
- Tests pin session cwd vs
process.cwd(), Claude keep-disk, bundledenabled: false, Alt+D no-op, confirm-pane hints, and description-zone disable copy.
Operators could enable and disable plugins but not uninstall them, and the screen opened with no orientation. Alt+X removes owned installs from disk, drops path entries, and disables bundled plugins that cannot be deleted.
The how-to header advertises Alt+A even when no plugin row is focused. Disable settings writes share one helper, and path-drop no longer duplicates between owned and unowned path removes.
Runner glue now goes through executePluginRemove so ownership and settings policy are tested with session cwd, not process.cwd(). Missing paths outside the origin plugins root are refused instead of treated as already gone.
e72d92e to
3db70d3
Compare
1 participant
Summary
/pluginsuninstalls user, project, and path-installed plugins with Alt+X, and disables bundled plugins that cannot be deleted.~/.claude./pluginsopens with a how-to header matching the model-picker hint style.Verification
bun run typecheck,bun run build, andbun run testpassFixes CL-6887