Fix stale mention accept during overlay reopen

[TheGreatAxios]

Summary

• Mention overlay Enter splices only when the mention generation is current and a live @ token is under the cursor.
• Enter that fails those checks dismisses the popup and bumps generation so an in-flight lookup cannot reopen or splice a stale completion.
• Dismiss clears the mention accept handler.

Verification

• bun run check exits 0 (5912 pass, 0 fail)
• bun test ./src/tui/mention-popup.test.ts ./src/tui/prompt-features.test.ts exits 0 (39 pass)

Fixes CL-6718

[linear-code]

CL-6718

[TheGreatAxios]

Review · Approve

Mention overlay Enter only splices a live @ token on the current generation; stale Enter dismisses so in-flight lookups cannot reopen.

No findings.

[TheGreatAxios]

Review · Comment

Mention overlay Enter only splices a live @ token on the current generation; stale Enter dismisses so in-flight lookups cannot reopen.

No blocking findings. GitHub forbids self-approve on this PR.

Notes

• src/tui/mention-popup.test.ts:384 — in-flight dismiss coverage goes through closeMentionPopup, not Esc/closeInsetOverlay.

[TheGreatAxios]

Critic · Comment

Accept is gated on current generation plus a live @ token; dismiss bumps generation and drops accept state. No blocking product defect.

Findings

• src/tui/mention-popup.test.ts:384 — should-fix coverage: dismiss-during-lookup uses closeMentionPopup, not operator Esc (closeInsetOverlay at src/tui/shell.ts:4079).
• src/tui/mention-popup.test.ts:361 — failed-reopen then Enter hits the permissions overlay, so it does not uniquely prove the mention live-gate.
• src/tui/shell.ts:5084-5112 — file-for-later: first lookup does not re-parse @ after await before opening the popup; Enter still refuses a stale splice.

[TheGreatAxios]

Greybeard · Comment

Hold. Splice coordinates belong at accept time; mentionGenerations already owns lookup currency; dismiss including non-live Enter must bump that same token.

acceptOverlaySelection classifying stale Enter as dismiss is the right host special-case (src/tui/shell.ts:4455-4458). Gates only in onAccept would echo a choice and leave an in-flight lookup able to reopen. mentionAcceptIsLive and onAccept are two decisions with close in between, not dual ownership.

[TheGreatAxios]

Neckbeard · Comment

Hygiene only; not blocking.

• src/tui/shell.ts:5155 and src/tui/shell.ts:5115 — mentionAcceptIsLive and onAccept repeat the same three predicates.
• docs/TUI.md:553 — "accept handler" names a WeakMap delete, not the overlay callback.
• src/tui/mention-popup.test.ts:280 — describe title includes the ticket id.
• src/tui/mention-popup.test.ts:324 — three await Promise.resolve() as a flush, copied from type().

[TheGreatAxios]

Addressed review findings: Esc/closeInsetOverlay during an in-flight lookup now bumps generation; accept requires the same live @token the lookup started on; tests cover Esc, vanished token, and a different @token.

[TheGreatAxios]

Review · Comment

Mention overlay Enter splices only the live @ token the current lookup armed; stale Enter dismisses so an in-flight lookup cannot reopen.

No blocking findings. GitHub forbids self-approve on this PR.

CI is green on HEAD (f617263e).

[TheGreatAxios]

Critic · Comment

Dismiss clears accept state and bumps generation. Accept requires current generation plus a live parse of the same @. Enter during an in-flight lookup dismisses instead of splicing.

No blocking product defect.

Findings

• src/tui/mention-popup.test.ts:339 — should-fix coverage: there is no hangable case for Enter while a no-match re-query is in flight (resolveNext([]) after dismiss). Same generation bump as the mid-reopen test; the issue asked for both races as permanent coverage.

[TheGreatAxios]

Greybeard · Comment

Proceed. Failed mention Enter as dismiss belongs at acceptOverlaySelection; generation owns lookup currency; live parseAtState owns splice coords.

The host gate is scoped to the @ popup claim (kind === "mentions" && mentionPopups.has(shell)). Successful accept deletes that claim before closeInsetOverlay so the close is not a dismiss bump. Do not add a third mention-kind check in the host.

[TheGreatAxios]

Neckbeard · Comment

Hygiene only; not blocking.

• src/tui/shell.ts:5141 — splice path hand-rolls the three assignments editPromptAt already does (src/tui/shell.ts:5196).
• src/tui/shell.ts:5180 — mentionAcceptIsLive is only liveMentionAccept(shell) !== null and has one call site.
• src/tui/mention-popup.test.ts:339 — “mid-reopen” names the old close-then-reopen path; the hot path is in-place refresh.
• src/tui/mention-popup.test.ts:463 — “Esc” test calls closeInsetOverlay, not an Escape key.
• src/tui/mention-popup.test.ts:358 — closed-state asserts .not.toBe("mentions") instead of overlayKind === null.