Unify the check gate with CI's test command - #769
Merged
TheGreatAxios merged 2 commits intoSep 4, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
bun run check ran the guard, not the test suite, while CI ran the suite itself, so a local green could mask CI failures. test now holds the seeded randomized suite; check, the guard, and CI all resolve to it.
The negative assertion missed the likeliest regression: an unguarded run: bun run test step in CI, which passes both prior checks while reintroducing the drift and skipping the projects-dir sandbox. Pin the anchor to end-of-line and note the guard scope in CONTRIBUTING.
TheGreatAxios
force-pushed
the
cl-7300-unify-bun-run-check-with-ci-so-a-local-green-cannot-mask-a
branch
from
September 4, 2026 04:47
ec0577c to
a5d4742
Compare
TheGreatAxios
enabled auto-merge
September 4, 2026 04:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun run checknow runs the same seeded, randomized suite CI runs —bun test ./src ./tests ./evals --randomize --seed 424242— so a local green can no longer mask a CI test failurecheck:projects-dir-guardscript instead of duplicating the test command, so the two cannot drift againtestscript name and delegates tobun run test, keeping the suite command in one placetests/unit/check-gate.test.ts) enforces thattest,check, the guard, and CI resolve to the same seeded suiteVerification
bun run typecheckandbun run buildpass; the newtests/unit/check-gate.test.tspasses (3/3)guard-real-projects-dir.ts)bun run checkprocesses, so the final green runs as part of this PR's CI checksFixes CL-7300