Collapse the three runtime bootstraps into shared session assembly - #777
Merged
TheGreatAxios merged 1 commit intoSep 4, 2026
Conversation
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Primary · Approve
Shared assembly plus live getters. /clear rebuilds against the new workdir; crash finalize and compaction mode follow the loop lets.
Residual, not blocking:
- Diff is net +752 (1787/1035), so the issue's 300–500 net-negative box stays open.
- No driven TUI session or headless exec run in this pass — suite only (
bun run typecheck/build/test).
TheGreatAxios
commented
Sep 4, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critic · Comment
No blocking defects on the tree as it stands. Live getWorkdir / getCompactor run inside buildAgent; crash identity rebinds via bindLiveSession.
Not blocking:
inactivityTimeoutMs/totalTimeoutMsstill snapshot at assemble time. No current path reassigns them before rebuild.createPluginsAdminhas no dedicated tests after the extract (origin had none either).
TUI and exec each hand-wired the same factories; every new runtime dependency was a three-site edit and a drift source. Shared assembly keeps live values behind getters so session rotation still hits the new workdir.
TheGreatAxios
force-pushed
the
cl-6810-collapse-the-three-hand-wired-runtime-bootstraps-2148-line
branch
from
September 4, 2026 06:23
8590019 to
264e13d
Compare
TheGreatAxios
enabled auto-merge
September 4, 2026 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
| undefinedso forwarding needs no conditional spreadsVerification
bun run typecheck,bun run build, andbun run testpassFixes CL-6810