Require operator confirmation for project approvals file grants - #935
Merged
TheGreatAxios merged 3 commits intoSep 12, 2026
Merged
Conversation
A repo-committed .corbits/permissions.json previously seeded the permission gate with zero operator involvement, so a planted file could silently auto-allow destructive calls such as force-pushes and file writes. Gate loadProjectApprovals behind per-entry grant fingerprints stored in the existing project-trust record: an untrusted directory now contributes zero approvals, trust stays keyed by realpath, and the first encounter with an unconfirmed file surfaces what it would grant instead of dropping it silently. Project trust never implies grant trust — each entry needs its own confirmation, recorded when the operator persists a project-scope grant. Covers CL-7782.
Hand-removing an entry from the project approvals file left its trust fingerprint behind, so a byte-identical replant applied silently. Loaders now reconcile trust against the entries on disk.
TheGreatAxios
deleted the
cl-7782-a-repo-committed-corbitspermissionsjson-grants-itself
branch
September 12, 2026 05:20
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements CL-7782: a repo-committed .corbits/permissions.json previously seeded the permission gate with zero operator involvement, so a planted file could silently auto-allow destructive calls (force-push, file writes).
What changed:
Verification: bun run check green (6983 pass, 0 fail, exit 0), including new regression tests in src/permission/project-approvals-trust.test.ts driving the real gate (planted force-push + write_file patterns must ask when untrusted, apply silently when trusted + confirmed; realpath/symlink case; first-encounter surfacing).
Not merging — lands after critique.