Resolve symlinks before the shell secret denylist - #950
Merged
Conversation
A benign-named symlink into a secret file asks exactly like the secret name itself, while pure name-listings still list freely.
TheGreatAxios
force-pushed
the
cl-7790-shell-tokens-resolved-paths
branch
from
September 12, 2026 18:09
73b6050 to
547e851
Compare
Bare tokens with no dot or slash skipped the resolve leg, so a link named notes into .env auto-allowed where notes.txt asked. Bare non-flag tokens now pay one lstat probe; a hit resolves the target and a miss stays syscall-free past that probe. Home expansion puts the secret reason on cat ~/notes instead of the coincidental outside-workspace ask, and the path-like comment no longer claims globs cannot reach secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run lint,bun run typecheck,bun run buildpassFixes CL-7790