Ship keepstyle guideline split and dedupe worker report envelopes - #968
Merged
Conversation
Collaborator
Author
|
Audit: envelope direction is correct — scaffold owns the Summary/Findings/Blockers/Paths shape, lane packages point at it instead of re-specifying it. Endorsed. Two issues to fix before merge:
Note: this PR wins the envelope question vs #954 — #954 must yield its in-package report format to this scaffold-owned shape. |
Reject unknown promptSectionOmit ids in ProfileSchema via type.enumerated over GUIDELINE_SUB_BLOCK_IDS so profile typos fail closed at load instead of silently keeping the full guidelines. Type omit as GuidelineSubBlockId end to end and drop the unwired KEEPSTYLE_PROMPT_SECTION_OMIT export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GUIDELINE_SUB_BLOCK_IDS) with an id-based omit policy, so config profiles can ship a smaller keepstyle footprint viapromptSectionOmitwithout prose surgery.KEEPSTYLE_PROMPT_SECTION_OMIT:responseStyleand scope/conventions (build gate, verification evidence) stay;toolChoice,askVsProceed, andorchestrationdrop. Omitting the config keeps full guidelines, so the default prompt is unchanged.Why: keepstyle models pay prompt tokens for guidance they never act on, and envelope re-specs drift into competing taxonomies; one policy surface and one envelope owner fix both.
Verification
bun test src/agent/prompts.test.ts src/agent/directors/intern/package.test.ts src/agent/directors/testsmith/package.test.ts src/agent/directors/neckbeard/package.test.ts src/agent/directors/bruckheimer/package.test.ts src/agent/directors/draper/package.test.ts— 88 pass, 0 fail (exit 0)bun run check— green: lint + typecheck + build + guard, then 7137 pass, 0 fail across 488 files (exit 0)guidelineConfigthreads throughbuildChatSystemPrompt, and the four-heading envelope appears exactly once in built sub-agent prompts; director tests assert packages no longer re-specify## Findings/## Blockers/## Pathsbun scripts/eval-capability.ts --matrix <cells> --dry-run— lists cases x variants with zero spend; drop--dry-runto run post-rebase with configured credentialskimi-k2.7-code) includedFixes CL-7654