Unify provider identity lists around the first-class registry - #970
Merged
Conversation
The ChatGPT-OAuth fallback defaulted to a different model than the OpenAI API-key path while both serve OpenAI, so the picker and the catalog disagreed per auth path. The live-fetch fallbacks stay separate - they back live calls - and a divergence test now pins the agreement instead of merging the lists.
Collaborator
Author
|
Audit: Approve, no findings. The unification is sound: FIRST_CLASS_PROVIDERS is the canonical static registry, the Codex/xAI live-fetch fallbacks stay separate, and identity-divergence.test.ts pins their agreement, including the gpt-5.4 default alignment across both OpenAI-serving auth paths. Stored-default-guard evidence: applyPersistedOAuthDefaults (src/config/index.ts:113) folds any persisted settings.providers defaultModel into the projected registry entry, prepending it when unknown, so a stored default can neither silently revert nor dangle after this change. One-word nit applied and pushed as 1147b4a: this shim only renames -> this alias only renames in the xai constants comment, matching the Local alias header one line up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FIRST_CLASS_PROVIDERSis the canonical static registry for provider identity; the Codex/xAI live-fetch fallbacks stay separate and a divergence test pins their agreementVerification
bun run typecheck,bun run build, andbun run testpassbun run checkpasses: 7138 pass, 0 fail across 489 filesOperator note: fresh ChatGPT-OAuth default flips gpt-5.5 → gpt-5.4 to match the OpenAI API-key path (CL-5691).
Fixes CL-5691