Skip to content

Split deep review from pull request surface review - #971

Merged
TheGreatAxios merged 3 commits into
mainfrom
cl-7345-review-skill-split
Sep 13, 2026
Merged

Split deep review from pull request surface review#971
TheGreatAxios merged 3 commits into
mainfrom
cl-7345-review-skill-split

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • /review classifies the target first, then dispatches a selected fleet
  • /pull-request-review keeps the worktree checkout plus a surface pass, loading /review for quality rules only

Verification

  • bun test tests/unit/corbits-skills-catalog.test.ts tests/unit/skills.test.ts tests/unit/skill-commands.test.ts passes (40 pass, 0 fail)
  • bun run check passes (7134 pass, 0 fail)

Fixes CL-7345
Related to CL-7037

@linear-code

linear-code Bot commented Sep 13, 2026

Copy link
Copy Markdown

CL-7345

CL-7037

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Audit: the review / pull-request-review split is the right shape (classify-then-dispatch, worktree checkout on the PRR side, quality rules owned by review). Two doc issues to fix:

  1. Fleet-routing contradiction in review/SKILL.md ("Classify, Then Dispatch a Selected Fleet": "dispatch a selected fleet with spawn_agent"). ARCHITECTURE.md/PRODUCT.md state the scope principle that skills do not assign identity or route the fleet — that stays on director system prompts. A skill body telling the primary to spawn_agent named directors is routing. Reframe: the skill classifies and recommends the fleet shape; the primary (director prompt authority) does the dispatching.
  2. Worktree ownership needs one line: review/SKILL.md says "read the PR tree (fetch the PR branch into a worktree)" while pull-request-review/SKILL.md owns worktree checkout — state which skill owns creating the worktree vs consuming it so the two do not both claim setup.

Note: docs collision with #961 — both PRs edit the same ARCHITECTURE.md/PRODUCT.md skill-list sentences (this PR rewords the /review + /pull-request-review clauses; #961 appends /lexicon). Whoever merges second rebases the sentence; flagging so neither side is surprised.

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Audit (fleet builder): routing contradiction fixed, ownership clarified.

  1. Fixed (pushed): the skill told the primary to dispatch fleet with spawn_agent (Classify, Then Dispatch a Selected Fleet) while PRODUCT.md holds that skills do not assign identity or route the fleet — routing stays on director system prompts / the Skywalker orchestrator. The section is now Classify, Then Recommend: the skill classifies and recommends warranted lenses, the primary dispatches. This also lines up with /pull-request-review Step 8, which already says to skip review's classify-and-dispatch.

  2. Fixed (pushed, one line): worktree ownership — the skill previously fetched the PR branch into a worktree itself; it now reads the PR tree from the worktree and states checkout belongs to /pull-request-review, matching PRODUCT.md's split.

Docs-collision note: this PR and #961 touch the same ARCHITECTURE/PRODUCT skill-list lines — whoever merges second should re-check those paragraphs for duplicate drift (particularly the /review one-liner vs the recommend reframing here).

Skills do not route the fleet: classify-and-recommend, primary dispatches. Worktree checkout belongs to pull-request-review.
@TheGreatAxios
TheGreatAxios force-pushed the cl-7345-review-skill-split branch from 7e5a0eb to 049ee93 Compare September 13, 2026 05:54
@TheGreatAxios
TheGreatAxios merged commit e42b490 into main Sep 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant