Document catalog credential-removal convergence as rebuild-only - #972
Merged
Conversation
Collaborator
Author
Audit: NEEDS-WORK (overbroad "never deleted") + merge noteFinding: "Manual rows are never deleted — settings-file providers are re-projected verbatim" overstates the invariant: #973's bare-row dedupe in this same function ( Merge note: this PR and #973 touch adjacent hunks of |
Every catalog rebuild derives rows from the current settings file plus the live credential stores, so removal converges on the next rebuild and manual rows are never deleted. A disabled flag has no home and no removal event to drive it.
The legacy bare codex/xai settings row is dropped once its family has a live credential-backed profile (CL-5606), so settings rows are verbatim except for that dedupe.
TheGreatAxios
force-pushed
the
cl-5446-catalog-removal-convergence
branch
from
September 13, 2026 05:39
b084026 to
132006f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credential-removal convergence for the model catalog is rebuild-only, documented at the reconcile funnel (
mergeOAuthCataloginsrc/config/index.ts) with a regression test pinning the behavior.Decision: document restart-only, not a disabled flag
Disable proved structurally wrong here, so per the brief I took the document path:
ProviderCatalogEntry,ProviderSettings, or theModelCatalogOptionrows the picker consumes.providerCatalogToSettings), plus threading through the catalog-to-picker mapping and the product-host boundary — with no removal event to drive it. There is no logout/disconnect surface and no auth-store watcher; refresh runs on connect, prefetch, and startup, so even a perfect flag would only converge on the next rebuild.Operational model: removal takes effect on the next rebuild (restart, provider connect, or model prefetch), not live. No behavior changed; no docs touched, so PR #265 doc accuracy is intact.
Verification
bun test src/config.test.ts -t "catalog credential-removal convergence"— 2 pass, 0 fail (exit 0)bun run check(lint + typecheck + build + projects-dir guard + full suite) — exit 0; 7133 pass, 0 fail across 488 filesFixes CL-5446