Strip scheduler restatements from the Skywalker prompt - #974
Merged
Conversation
Collaborator
Author
|
Audit: Needs-work, fix now pushed as 1c93834. Loop repro: the branch deleted "Cap is one successor for that stall" while keeping MAY spawn_agent one successor with a changed brief per stall. Each stall permits one successor but nothing terminates the chain: the successor stalls, its stall permits another one successor, ad infinitum, with each step plausibly changed enough to pass the identical-re-dispatch guard. Fix restores the qualitative bound (one successor per stall, then synthesize + Blockers and stop), pinned by expect(p).toContain("Cap is one successor for that stall"). Checks on the branch: bun run typecheck exit 0; bun test skywalker + prompts suites 44 pass, 0 fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheckpasses (exit 0)bun run lintpasses (oxfmt + oxlint, 0 warnings, 0 errors)bun run buildpassesbun test ./src ./tests ./evals ./scripts --randomize --seed 424242passes (7131 pass, 0 fail, 488 files)src/subagent/admission.ts:137,194(queueing + width caps) — deletedqueues excessrestatementsrc/subagent/admission.ts:64(laneDisjointness) — deleted queue-depth restatementCap re-fix rounds (e.g. 1-2)is deleted while the loop judgment (ship -> verify -> fix -> re-verify) is keptsrc/subagent/agent-fleet.ts:510(spawn returns immediately),src/subagent/exec/runner.ts:144,src/agent/agent-search.ts:114— deleted mount-fact and triple-stated contract restatements; kept the fail/successor/interrupt/cancel judgmentsrc/agent/directors/skywalker/package.ts, markers): that branch compresses classification while this one strips scheduler prose — the second to land rebasesFixes CL-6953