Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 0 additions & 101 deletions src/agent/directors/bake-skills.test.ts

This file was deleted.

90 changes: 0 additions & 90 deletions src/agent/directors/bake-skills.ts

This file was deleted.

5 changes: 3 additions & 2 deletions src/agent/directors/builder/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,14 @@ describe("builderPackage", () => {
expect(p).toContain("`/implement` does not steal planning from `/plan`");
});

test("systemPrompt requires baked core constraints and Ponytail prerequisites", () => {
test("systemPrompt requires core constraints and Ponytail prerequisites", () => {
const p = builderPackage.systemPrompt;
expect(p).toContain("Prerequisites");
expect(p).toMatch(
/style, philosophy, native-runtime, idiot-proof, and Ponytail/i,
);
expect(p).toMatch(/use_skill is not mounted/i);
expect(p).toMatch(/load each with skill_search \+ use_skill/i);
expect(p).not.toMatch(/use_skill is not mounted/i);
expect(p).toMatch(
/including their TypeScript conventions when TypeScript is the task surface/i,
);
Expand Down
2 changes: 1 addition & 1 deletion src/agent/directors/builder/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ You are a disciplined implementer worker (maySpawn:false) — not Critic, not Ex

## Prerequisites

Before substantial repo work: follow style, philosophy, native-runtime, idiot-proof, and Ponytail (baked; use_skill is not mounted). Follow AGENTS.md and /docs, including their TypeScript conventions when TypeScript is the task surface.
Before substantial repo work: follow style, philosophy, native-runtime, idiot-proof, and Ponytail — load each with skill_search + use_skill only when the brief needs it. Follow AGENTS.md and /docs, including their TypeScript conventions when TypeScript is the task surface.

## Plan

Expand Down
3 changes: 2 additions & 1 deletion src/agent/directors/critic/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ describe("criticPackage", () => {
test("tools.allow is review surface with product writes", () => {
const allow = criticPackage.tools?.allow ?? [];
expect(allow).toContain("read_file");
expect(allow).not.toContain("use_skill");
expect(allow).toContain("skill_search");
expect(allow).toContain("use_skill");
expect(allow).toContain("write_file");
expect(allow).toContain("edit_file");
expect(allow).toContain("delete_file");
Expand Down
2 changes: 1 addition & 1 deletion src/agent/directors/critic/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ API contract check (blocking when brief specifies signatures):
- Prefer reading tests/callers; a tiny sync call that would hang on a Promise is evidence.
- Rank these as blocking, not style nits.

Before substantial review work: follow style, philosophy, native-integration, and idiot-proof (baked; use_skill is not mounted). Read the code under review.
Before substantial review work: follow style, philosophy, native-integration, and idiot-proof — load each with skill_search + use_skill only when the brief needs it. Read the code under review.

OUT OF LANE → refuse or reclassify under Blockers:
- implementing fixes (route to builder)
Expand Down
3 changes: 2 additions & 1 deletion src/agent/directors/draper/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ describe("draperPackage", () => {
test("tools.allow is review surface with file writes for evidence tests", () => {
const allow = draperPackage.tools?.allow ?? [];
expect(allow).toContain("read_file");
expect(allow).not.toContain("use_skill");
expect(allow).toContain("skill_search");
expect(allow).toContain("use_skill");
expect(allow).toContain("write_file");
expect(allow).toContain("edit_file");
expect(allow).toContain("delete_file");
Expand Down
3 changes: 2 additions & 1 deletion src/agent/directors/emil/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ describe("emilPackage", () => {
test("tools.allow is review surface with product writes", () => {
const allow = emilPackage.tools?.allow ?? [];
expect(allow).toContain("read_file");
expect(allow).not.toContain("use_skill");
expect(allow).toContain("skill_search");
expect(allow).toContain("use_skill");
expect(allow).toContain("write_file");
expect(allow).toContain("edit_file");
expect(allow).toContain("delete_file");
Expand Down
4 changes: 2 additions & 2 deletions src/agent/directors/greybeard/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ PRIMARY INTENT: architecture judgment. Judge approach soundness, constraint owne

You are Greybeard — not a second Skywalker, not Critic (code defects with evidence), not Builder. Your value is architectural judgment, not legwork or implementation.

Follow style and philosophy conventions (baked into this prompt) when reviewing plans or approaches — skills are active constraints, not background docs.
Follow style and philosophy conventions (load on demand with skill_search + use_skill) when reviewing plans or approaches — skills are active constraints, not background docs.

Your value is analysis, not delegation: reach the judgment yourself with
targeted reads (read_file, grep) and pointed questions (ask_director)
Expand All @@ -44,7 +44,7 @@ Blinders: do not call search_agents to discover the fleet. Do not spawn builder,

Guide quality — advise what good architecture looks like for this change. Do not assert enforcement theater (fake caps, pretend runtime gates, or "must spawn N" rules the harness does not enforce).

Before substantial review work: follow style and philosophy conventions (baked; use_skill is not mounted on workers).
Before substantial review work: follow style and philosophy conventions — load each with skill_search + use_skill only when the brief needs it.

OUT OF LANE: shipping product code, pedantic style-only nitpicking, being a second primary orchestrator, discovering or dispatching the full fleet.`,
};
Loading
Loading