Skip to content

Restore Emil critique layer from the CMO original at full fidelity - #999

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-7800-restore-emil-cmo-copymessaging-layer-at-full-fidelity
Sep 14, 2026
Merged

Restore Emil critique layer from the CMO original at full fidelity#999
TheGreatAxios merged 2 commits into
mainfrom
cl-7800-restore-emil-cmo-copymessaging-layer-at-full-fidelity

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Fresh PR superseding #954 (stale head, swapped branch name). Closes CL-7800. Budgets recomputed post-yield: 24800/26000.

The design-eng overhaul had narrowed the prompt to a laws digest; port back every dropped section from the CMO source. Deviations are enumerated in the package header.
The shared scaffold owns Summary / Findings / Blockers / Paths, so the restored CMO report content is carried as Findings sub-bullets instead of re-specified headings. Deviation comment 5 updated to match.
@linear-code

linear-code Bot commented Sep 13, 2026

Copy link
Copy Markdown

CL-7800

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Critic review · Approve

Restores the Emil critique layer from the CMO original at full fidelity over the CL-7031 digest; still needed (954 closed unmerged, restore not in main). Merge-ready, no blocking findings.

Verification (evidence, not vibes)

  • src/agent/directors/emil/package.ts — every restored section present in the PR prompt: Thinking & reasoning laws (First Principles, Inversion, Map Is Not the Territory, Gilb's Law), Boy Scout Rule, tmp/critique-tests temp-test workflow with discard-on-disproof, cross-reference checklist (will-change, scale-on-press, hit areas), guidelines + negative constraints. Confirmed via pattern match against the PR head.
  • src/agent/directors/emil/package.test.ts — tests are real: all new positive assertions match PR prompt content; all negative assertions (no standalone report headings, no tool-schema restatement) hold with zero matches; description assertions match. Both files pass TS transpile; bun test on src/agent/directors/emil/ plus src/agent/prompt-sizes.test.ts on main is 19 pass / 0 fail.
  • Budget: restored grok prompt estimates ~22778 chars / ~22930 bytes vs the checked-in CL-7801 baseline (22770/22922) and 24800/26000 budget — fits with headroom. The 24800/26000 claim in the PR body checks out arithmetically.
  • Hygiene matches the merged draper (CL-7800) precedent: provenance header with exhaustive deviations list, REVIEW_TOOLS (product writes for temp tests only), maySpawn false, review/leaf. Scope is exactly the two emil files.

Nits (non-blocking)

  • package.ts:10 — primaryIntent still says "laws review" while prompt/description say "critique"; skywalker and rand refs also say "laws review". Keeping the old term is the consistent call — just noting the drift.
  • package.ts — "Do not commit changes" kept verbatim for fidelity, while draper deliberately dropped it as harness-owned. Documented deviation; fine, but the two siblings now disagree on that norm.
  • Report deferral (scaffold-owned envelope) differs from draper's "Report shape:" convention. Emil's is the newer pattern; consider converging draper later, not here.

Note on CL-7800

CL-7800 being Done does not make this duplicative: this PR is the CL-7801 emil restore, 954 was closed unmerged, and main still carries the narrowed digest prompt. This is the only vehicle for the restore.

@TheGreatAxios
TheGreatAxios marked this pull request as ready for review September 14, 2026 04:52
@TheGreatAxios
TheGreatAxios merged commit 7e556ce into main Sep 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant