feat(mailbox): default mountMailbox's SSE bus to in-process (CL-8775) - #30
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #28 so that PR stays docs-only.
MountMailboxOpts.busbecomes optional and defaults tocreateInMemoryMailboxEventBus(). The bus only carries SSE live updates; mail itself is Postgres. A single-process host can omit it; several hub processes must still pass a shared bus, or live updates won't cross processes.Open question before merging: this is a silent default. A multi-process host that forgets
busloses cross-process live updates with no error.Once #28 lands, the README's
busrow needs to say optional.