CL-6439: prove and lock the template-block deploy freeze - #180
Merged
Merged
Conversation
The template-block deploy now freezes its serialized definition through @corbits/workflow-freeze (CL-6439), so a block edit that names an unresolvable director or an unprojectable step would turn the deploy route into a 500. Lock the freezability of the code-review block source: projection covers every step, the hash computes, and the capability walk reports a non-empty grant surface. bun.lock also picks up bun's re-normalization of stale aliased entries from installing the new workspace devDependency.
The factory eval scoreboard's gap 1 (DefinitionProjectionMissingError on a webhook-fired launch) is closed: the template-block deploy freezes its definition through @corbits/workflow-freeze, and a plumbing-mode run confirms the fired trigger answers 202 with a real run instance. Scorers #5/#6 now block only on a live EVAL_PROVIDER_API_KEY run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The last product gap on the GitHub code-review demo path: template-block deploys (POST /template-blocks/:assetName/deploy) used to record no frozen wire projection, so a webhook-fired launch 500d with DefinitionProjectionMissingError.
The call-site cutover to @corbits/workflow-freeze landed with #179 (the hub's deployWorkflowSource binding now calls freezeInertWorkflowDefinition). This PR closes CL-6439's remaining halves:
packages/workflow-catalog/test/block-workflow-freeze.test.tslocks the code-review block source's freezability — projection covers every step, the hash computes, the capability walk resolves every director and reports a non-empty grant surface. A block edit that broke any of those would turn the deploy route into a 500, and now fails here first.Red -> green evidence
A plumbing-mode run of the
github-pr-review-factorycase against a scratch hub (real install route, real ingress route, HMAC-signed delivery):created [correctness-reviewer, architecture-reviewer, release-risk-reviewer], deployed blocks [code-review], webhook triggers started: 1webhook delivery accepted: instance run_ce34bc... at run_ce34bc...@...— 202 with a real run instance, no DefinitionProjectionMissingErrorsuggestedFixesStructurallyValid's failure reason flipped from the launch 500 to "no successful github_post_pr_review call yet" — the documented live-key gap (scorer full-green needs EVAL_PROVIDER_API_KEY; plumbing mode's stub credential can never post a review).Fixes CL-6439