Wait for the Slack reply instead of assuming the microtask drained - #218
Merged
Merged
Conversation
The reply lands on a later microtask than the dispatch resolves, so the assertion passed locally and failed on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@corbits/slack-tag's "relays the agent's reply back to the Slack thread" test asserted onthread.postsimmediately afterdispatchWorkbenchSlackEventresolved, while the fake fires the reply from aqueueMicrotask. How many turns of the loop that takes is an implementation detail — it drained in time locally (41 pass, 5/5 runs) and did not on CI. Now waits for the post itself.