Skip to content

CL-6496: a global error sink #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 4 commits into from
Aug 21, 2026
Merged

CL-6496: a global error sink #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c6f475
Add tests for the error-sink structured error convention (CL-6496)
TheGreatAxios Aug 21, 2026
c162861
Add @corbits/error-sink: structured errors on @intx/log (CL-6496)
TheGreatAxios Aug 21, 2026
03063ec
Update docs: @corbits/error-sink's consolidation reasoning and the cl…
TheGreatAxios Aug 21, 2026
f101839
Report resolveFallbackWorkbenchId's swallowed error through error-sink
TheGreatAxios Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/hub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"@corbits/bench": "workspace:*",
"@corbits/chat": "workspace:*",
"@corbits/commands": "workspace:*",
"@corbits/error-sink": "workspace:*",
"@corbits/credential-providers": "workspace:*",
"@corbits/docker-provisioner": "workspace:*",
"@corbits/e2b-sandbox-sidecar": "workspace:*",
Expand Down
11 changes: 10 additions & 1 deletion apps/hub/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ import {
workbenchLaunchPersistExtra,
} from "@corbits/chat";
import type { RelaunchNoticePort } from "@corbits/chat";
import { reportError } from "@corbits/error-sink";
import type { FinalizedTurnToolCall } from "@corbits/turn-artifacts";
import { decodedOrNull } from "@corbits/url-path";
import {
Expand Down Expand Up @@ -2385,7 +2386,15 @@ export async function createHub(config: HubConfig) {
myraDefinitionId,
);
return chat?.workbenchId;
} catch {
} catch (cause) {
// Best-effort fallback lookup (CL-6496): a failure here means
// the task orchestrator falls back further, never that the
// caller sees an error -- but that made this failure invisible
// until reportError existed. Reported, not swallowed.
reportError(cause, {
operation: "resolveFallbackWorkbenchId",
tenantId,
});
return undefined;
}
},
Expand Down
34 changes: 32 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading