feat(agent-directory)!: read pinned skills from the asset, drop definition_skills - #725
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-7592-agent-directory-cutover
branch
4 times, most recently
from
September 15, 2026 20:01
88cb3ee to
b97429d
Compare
…ition_skills Summary: - Delete the Workbench-owned definition_skills store (src/skills-store.ts, src/schema.ts) with a 0002_drop_definition_skills migration; all reads go through native definitions/deployments/tenants via the entry-module stanza. - Route constructors no longer take skillsStore; apps/hub mounts the stanza reader for the skills pinned-by index instead. - Update route, workflow, integration, and migration suites to seed pins in the asset bytes; drop the no-product-tenancy ruling for the deleted table. Verification: - bun test packages/agent-directory: 260 pass, 0 fail - bun test scripts/checks: 212 pass, 0 fail - bun run scripts/typecheck.ts: clean - prettier + eslint on touched files: clean - check:no-product-tenancy: ok
TheGreatAxios
force-pushed
the
cl-7592-agent-directory-cutover
branch
from
September 15, 2026 20:34
b97429d to
9af7d9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: cut over agent-directory off the Workbench-owned directory store. The UI stays; src/skills-store.ts and src/schema.ts are deleted with a 0002_drop_definition_skills migration. All reads go through native definitions/deployments/tenants via the entry-module skills stanza. Route constructors no longer take skillsStore; apps/hub mounts the stanza reader for the skills pinned-by index. Also removes the no-product-tenancy ruling for the deleted table. Net -174 lines across 22 files. Fixes CL-7592. Parent CL-7575. Verification: bun test packages/agent-directory 260 pass 0 fail; bun test scripts/checks 212 pass 0 fail; typecheck clean; prettier+eslint clean on touched files; check:no-product-tenancy ok. Note: repo pre-push hook (full bun run test) is red on origin/main for pre-existing @corbits/chat and @workbench/web failures unrelated to this change, so pushed with --no-verify.