Skip to content

fix(web): timeline body extraction descends signed multipart replies (CL-8444) #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 18, 2026
Merged

fix(web): timeline body extraction descends signed multipart replies (CL-8444) #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions apps/web/src/chat/threads-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,20 +134,29 @@ export function frameBody(raw: string): string {
} catch {
return "";
}
const text = decoded.replace(/\r\n/g, "\n");
const split = text.indexOf("\n\n");
if (split < 0) return "";
const headers = text.slice(0, split).toLowerCase();
const body = text.slice(split + 2);
const boundary = /boundary="?([^";\n]+)"?/.exec(headers)?.[1];
if (boundary === undefined) return body.trim();
for (const part of body.split(`--${boundary}`)) {
const partSplit = part.indexOf("\n\n");
if (partSplit < 0) continue;
if (!part.slice(0, partSplit).toLowerCase().includes("text/plain")) continue;
return part.slice(partSplit + 2).trim();
return textPart(decoded.replace(/\r\n/g, "\n")) ?? "";
}

/** First `text/plain` leaf of a MIME entity, descending nested multiparts
* (an agent reply is `multipart/signed` around `multipart/mixed`). The
* boundary is matched case-sensitively: it is a token, not a header name. */
function textPart(entity: string): string | undefined {
const split = entity.indexOf("\n\n");
if (split < 0) return undefined;
const headers = entity.slice(0, split);
const body = entity.slice(split + 2);
const boundary = /boundary="?([^";\n]+)"?/i.exec(headers)?.[1];
if (boundary === undefined) {
return /content-type:\s*text\/plain/i.test(headers) || !/content-type:/i.test(headers)
? body.trim()
: undefined;
}
for (const part of body.split(`--${boundary}`).slice(1)) {
if (part.startsWith("--")) break;
const found = textPart(part.replace(/^\n/, ""));
if (found !== undefined) return found;
}
return "";
return undefined;
}

function addressRunId(address: string): string | undefined {
Expand Down
Loading