feat(web): new-workbench picker deploys chosen bench agents into the room (CL-8442) - #880
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-8442-room-agents
branch
from
September 18, 2026 05:44
cc5fdf4 to
1984ea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/src/git-fetch.ts: fetches one file out of a hub asset repo from the browser (isomorphic-git's upload-pack wire over the asset's smart-HTTP git remote, with a short-lived read-only token) — the read-side counterpart togit-push.ts.apps/web/src/agent-source-read.ts:readAgentSource(tenantId, assetId, assetName)mints acan_readgit token, fetches the workflow asset'smain, and parses itsworkflow.jsentry (parseWorkflowSourceEntry) back into{ systemPrompt, declaredSources }.apps/web/src/chat/threads-api.ts:ChatAgentnow carriesassetName(the raw workflow asset name, vs.name's display alias for Myra), and exportsisMyraAgentso pickers can exclude her.apps/web/src/pages/new-workbench-picker.tsx: restores the agent multi-select — lists the bench tenant's non-Myra chat agents vialistChatAgents, lets the person check which ones join the room.apps/web/src/workbench-create.ts:createWorkbenchtakespickedAgents; for each, reads its source off the bench tenant and re-deploys it into the child tenant viadeployAgentSource(same path Myra's own deploy uses — a child's deploy route rejects the parent's inherited asset).Upstream gaps
workflow-kind asset (onlypackage-registrytarballs get one — seevendor/intx/hub-api/src/routes/assets.ts's/:assetId/tarballsroute). Reading an agent's source therefore goes over the smart-HTTP git remote with a read-only token rather than a simple GET; flagged here per "upstream asks go to user," not filed anywhere.Test plan
bunx tsc -p apps/web --noEmit— cleanbun run fmt/bun run lint— clean (pre-existing sidecar warnings only, unrelated)bun test apps/web/src/workbench-create.test.ts apps/web/src/agent-deploy.test.ts apps/web/src/chat— no new failures (pre-existing jsdom-less failures inmarkdown.test.tsx/ tool-activity tests are unrelated to this change)