fix(web): approvals query polls while the chat's agent is live (CL-8499) - #897
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an optional
{ refetchInterval }option touseAPIQuery(apps/web/src/api.ts), threaded throughusePendingApprovals(apps/web/src/pending-approvals.ts). Chat thread and Workbench Room pages now poll the approvals query every 3s while the relevant agent is live, and stop polling once it isn't.Why
GET /api/tenants/:t/approvalsis not a mailbox event, so the SSE inbox subscription never invalidates the approvals query. A pending approval only showed up after a manual page reload.Verified
bunx tsc -p apps/web --noEmitbun run lintbun run fmtcd apps/web && bun run buildcd apps/web && bun test ./src(582 pass)