fix(web): tour shown once; Tools page lists the packages deployed agents carry (CL-8504) - #902
Merged
Merged
Conversation
…nts carry (CL-8504) The onboarding tour's close (X) button fired react-joyride's action 'close' without moving status to FINISHED/SKIPPED, so dismissing it that way never persisted and it replayed on the next mount. Also route Tools off each live agent's deployed definition.json (plus Myra's bundled mail/posix, which never lands there) instead of the stale corbits-tools package-registry asset.
A literal MYRA_TOOL_PACKAGES list in a new agents/myra/src/tool-packages.ts module was exactly the drift-prone duplicate the ground rules avoid, and it broke the agent-package-stays-trim rule. Derive the same list at read time from @intx/tools-* entries in @corbits/myra/package.json's own dependencies instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action: "close"without ever movingstatustoFINISHED/SKIPPED, somarkTourSeennever ran and the tour replayed on the next mount.handleCallbacknow also persists onACTIONS.CLOSE, and both localStorage reads/writes report throughreportError.corbits-toolspackage-registry asset (still holding deletedcorbits-*packages). It now lists the tool packages the tenant's live agent deployments actually carry: pins read off each agent's deployeddefinition.jsonvia a newreadAgentToolPackagePinsinagent-source-read.ts, plus Myra's bundled@intx/tools-mail/@intx/tools-posix, which never land in that file (added as a static, browser-safe@corbits/myra/tool-packagesexport). Rows show package name, version (or—when unpinned/bundled with no version tracked), and which agents carry it.tools/registry-read.tsis deleted — nothing else used it.Test plan
bunx tsc -p apps/web --noEmitbun run lintbun run fmtcd apps/web && bun run buildcd apps/web && bun test ./src(582 pass)