feat(web,myra): a mailed package can carry a cron schedule; Deploy creates the scheduled workflow (CL-8513) - #906
Merged
Conversation
…eates the scheduled workflow (CL-8513)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployable-package.tsnow parses an optionalschedule(a five-field cron string) ondefinition.json, validated by field count only (no third-party cron parser).cronSentence(schedule)under the name, or a clear error when the schedule isn't a valid five-field string (Deploy stays disabled in that case).agent-deploy.tsadds a stock{ type: "schedule", cron }trigger alongside the existing{ type: "mail", to }trigger whenscheduleis set — the same trigger shapevendor/intx/workflow/src/live-inert-projector.tsprojects forcase "schedule".NewAgentInputanduseDeployAgentMutationthreadschedulethrough as an optional key, omitted when undefined.schedulein the same sentence aspackage.json/definition.json.The deployment still lists on the Workflows page through the existing stock
GET /workflows/deploymentsread;routines-api.ts'scron: "manual"placeholder is unchanged since stock's deployment listing still doesn't expose trigger data.Test plan
bunx tsc -p apps/web --noEmitbun run lintbun run fmtcd apps/web && bun run buildcd apps/web && bun test ./src(582 pass)