Skip to content

fix(web): artifact rows match @corbits/artifacts 0.2.1 (no ownerName) (CL-8515) #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Sep 18, 2026
Merged

fix(web): artifact rows match @corbits/artifacts 0.2.1 (no ownerName) (CL-8515) #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const ArtifactListItemSchema = type({
source: "Record<string, unknown>",
version: "number",
ownerPrincipalId: "string | null",
ownerName: "string | null",
metadata: "Record<string, unknown> | null",
archivedAt: "string | null",
createdAt: "string",
updatedAt: "string",
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/chat-artifact-open.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function artifactDetail(overrides: Partial<ArtifactDetail>): ArtifactDetail {
source: { origin: "workflow", runId: "run_1" },
version: 1,
ownerPrincipalId: null,
ownerName: null,
metadata: null,
archivedAt: null,
createdAt: "2026-08-01T00:00:00.000Z",
updatedAt: "2026-08-01T00:00:00.000Z",
Expand Down
3 changes: 0 additions & 3 deletions apps/web/src/library/artifact-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ function metaLine(
now: number | undefined,
): string {
const parts: string[] = [];
if (artifact.ownerName !== null && artifact.ownerName !== "") {
parts.push(artifact.ownerName);
}
if (meta?.sourceChannel !== undefined && meta.sourceChannel !== null) {
parts.push(meta.sourceChannel);
}
Expand Down
1 change: 0 additions & 1 deletion apps/web/src/library/artifact-summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export const ArtifactSummary = type({
* "csv", "one-pager". Never a closed union: the hub cannot enumerate every
* kind a workflow might one day emit. */
kind: "string",
ownerName: "string | null",
createdAt: "string",
"updatedAt?": "string | null",
});
Expand Down
2 changes: 0 additions & 2 deletions apps/web/src/library/artifacts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ function artifact(overrides: Partial<ArtifactSummary> & { readonly id: string })
return {
title: "Untitled",
kind: "document",
ownerName: null,
createdAt: "2026-01-01T00:00:00.000Z",
...overrides,
};
Expand All @@ -22,7 +21,6 @@ describe("ArtifactSummary", () => {
id: "art_1",
title: "Q3 report",
kind: "deck",
ownerName: "Ada",
createdAt: "2026-01-01T00:00:00.000Z",
});
expect(parsed).not.toBeInstanceOf(Error);
Expand Down
3 changes: 0 additions & 3 deletions apps/web/src/pages/library-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ function ArtifactRows({
</TableHead>
<TableHead>Title</TableHead>
<TableHead>Kind</TableHead>
<TableHead>Owner</TableHead>
<TableHead>Updated</TableHead>
</TableRow>
</TableHeader>
Expand Down Expand Up @@ -161,7 +160,6 @@ function ArtifactRows({
<TableCell className="text-muted-foreground">
{artifactKindLabel(artifact.kind)}
</TableCell>
<TableCell className="text-muted-foreground">{artifact.ownerName ?? "—"}</TableCell>
<TableCell className="text-muted-foreground">
{formatRelativeTime(artifact.updatedAt ?? artifact.createdAt, now)}
</TableCell>
Expand Down Expand Up @@ -233,7 +231,6 @@ function PreviewPane({
{detail !== null ? (
<p className="truncate text-xs text-muted-foreground">
{artifactKindLabel(detail.kind)}
{detail.ownerName !== null ? ` · ${detail.ownerName}` : ""}
{` · Version ${detail.version}`}
</p>
) : null}
Expand Down
4 changes: 0 additions & 4 deletions apps/web/src/shell/library-artifacts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const sample: ArtifactListRow = {
id: "art_1",
kind: "file",
title: "Quarterly report.pdf",
ownerName: "Ada",
createdAt: "2026-01-01T00:00:00.000Z",
updatedAt: "2026-01-02T00:00:00.000Z",
};
Expand All @@ -30,7 +29,6 @@ describe("library-artifacts", () => {
id: "art_1",
title: "Quarterly report.pdf",
kind: "file",
ownerName: "Ada",
createdAt: "2026-01-01T00:00:00.000Z",
updatedAt: "2026-01-02T00:00:00.000Z",
});
Expand All @@ -42,13 +40,11 @@ describe("library-artifacts", () => {
id: "art_2",
kind: "document",
title: "notes.txt",
ownerName: null,
};
const mapped = mapArtifactListToSummaries([sample, second]);
expect(mapped).toHaveLength(2);
expect(mapped[0]?.id).toBe("art_1");
expect(mapped[1]?.kind).toBe("document");
expect(mapped[1]?.ownerName).toBeNull();
});

test("detects the unconfigured-plane status", () => {
Expand Down
2 changes: 0 additions & 2 deletions apps/web/src/shell/library-artifacts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export type ArtifactListRow = {
readonly id: string;
readonly kind: string;
readonly title: string;
readonly ownerName: string | null;
readonly createdAt: string;
readonly updatedAt: string;
};
Expand All @@ -34,7 +33,6 @@ export function artifactListRowToSummary(row: ArtifactListRow): ArtifactSummary
id: row.id,
title: row.title,
kind: row.kind,
ownerName: row.ownerName,
createdAt: row.createdAt,
updatedAt: row.updatedAt,
};
Expand Down
Loading