fix(web): Restart failures surface, no step timeout on deployed packages, roster Chat link navigates (CL-8521) - #914
Merged
Conversation
…ges, roster Chat link navigates (CL-8521)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useMutations inagents-page.tsxandchat-thread-page.tsx(two call sites) now haveonError: report throughreportError, toast stage copy when the cause is aWorkbenchCreateError, generic copy otherwise (describeRestartFailureinworkbench-create.ts, mirroringdescribeWorkbenchCreateFailure).buildAgentDefinitionJsonno longer emitstimeout: 120000on the deployed step — a step timeout stays armed across an approval park and would abort a run waiting on a person to answer an ask-gated tool call, same reasoning Myra's own definition already documents.FirstRunTour, mounted globally inAppShell) renders a full-page Joyride overlay that, by default, swallows clicks anywhere outside the current spotlight target. On/agents, the tour's step 1 spotlight only exposes the sidebar, so a click on the Chat link landed on the overlay instead of the anchor. AddedspotlightClicksto theJoyrideprops so the overlay's backdrop lets clicks pass through to the page underneath while still showing the tour visually.Verification
agent-browseragainst the running dev server: clicking the Chat link failed with "Element is covered by<div.react-joyride__overlay>" before the fix.bunx tsc -p apps/web --noEmit,bun run lint,bun run fmt,apps/webbun run build,apps/webbun test ./srcall pass.