fix(web): redeploy and room join reuse the agent's source slug; roster shows the agent's name (CL-8522) - #915
Merged
Merged
Conversation
…r shows the agent's name (CL-8522)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-echo-bot-source) was double-wrapping the asset name:deployAgentSourceslugified the raw asset name and re-wrapped it, minting a new asset likeagent-agent-echo-bot-source-sourceinstead of reusing the existing one.NewAgentInputnow takes an optionalslug, used verbatim (validated) instead of re-deriving one fromname.agentSlugFromSourceAssetNameis the inverse ofagentDeploySourceAssetName.redeployRoomAgentand the room-join loop increateWorkbenchnow derive the slug from the existingassetNameand pass it through, so a restart or room join reuses the same asset.displayAgentNamerenders a non-Myraagent-<slug>-sourceasset as its title-cased slug ("Echo Bot") instead of the raw asset name.Closes CL-8519.
Test plan
bunx tsc -p apps/web --noEmitbun run lintbun run fmtcd apps/web && bun run buildcd apps/web && bun test ./src(595 pass)