fix(web): agents are addressed only by run address (CL-8567) - #921
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scribe@<domain>) for a handoff instead of using the recipient's run address, and the hub dropped the message.Changes
apps/web/src/agent-deploy.ts,apps/web/src/myra-deploy.ts) clarifying the trigger'stovalue only feeds deploy-time mail grants and is not a routable address.Participants:block of incoming mail, and that an address must never be constructed from an agent's name/slug.apps/web/srcfor any UI surface printing a slug/trigger address as an agent's address; found none — the Agents page, room roster, and participants panel already resolve addresses from the live run/deployment listing (listRoomParticipants,chatAgents.liveAddress), so no UI changes were needed.Testing
bun test apps/web/src/agent-deploy.test.ts apps/web/src/myra-deploy.test.ts agents/myra/srcbun run check(typecheck, lint, fmt, test) — all green