feat(web): deploy schedules become cron rows addressed at the agent's run (CL-8534) - #925
Merged
Merged
Conversation
…(CL-8534) Reintroduce coverage for a deploy package's cron string ahead of restoring the schedule field, and update the routines fixture for the new schedule column.
… run (CL-8534) A deployed agent's optional five-field cron schedule now creates a @corbits/cron row addressed at that deploy's run, since Interchange's own schedule trigger is reserved but never fires. The Workflows page reads the schedule back by joining GET /cron against each deployment's run address, replacing the old "manual" placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schedule; on success it creates a@corbits/cronrow addressed at the deploy's run, since Interchange's ownscheduletrigger is reserved but never fires.GET /cronjoined against each deployment's run address) instead of the old "manual" placeholder.schedulefield, matching what PR refactor(web)!: drop the schedule trigger and cron column (CL-8527) #918 removed.Changes
apps/web/src/agent-deploy.ts:NewAgentInput.schedule, andscheduleAgentRunposts a cron row toPOST /api/tenants/:id/cron(expression,toAddress: run_<id>@<domain>, subject "Scheduled run", body "This is your scheduled run. Do the work your definition describes and reply with the result.") after a successful deploy.apps/web/src/chat/deployable-package.ts: restores theschedule?field andisFiveFieldCronshape check on the deploy package contract.apps/web/src/chat/message-attachments.tsx: shows the schedule's cron sentence on the deploy card, disables Deploy on an invalid schedule, and forwards it to the deploy mutation.apps/web/src/routines-api.ts: adds aCronSchedulearktype schema andlistCronSchedules, and joins cron rows ontoScheduledWorkflowDefinition.scheduleby the deployment's run address (same joinchat/threads-api.tsuses for a chat agent's live address).apps/web/src/pages/routines-page.tsx/routine-detail-page.tsx: render the joined schedule instead of the removed cron column/sentence.agents/myra/src/system-prompt.ts: mentions the optional cronschedulein the definition contract again.Testing
bun test apps/web/src/chat/deployable-package.test.ts apps/web/src/insights-stats.test.ts apps/web/src/agent-deploy.test.tsbun run check(typecheck, lint, fmt, full test suite) — green.